Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOS node location and add a smoke test #4996

Closed
wants to merge 2 commits into from
Closed

Fix MacOS node location and add a smoke test #4996

wants to merge 2 commits into from

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Sep 26, 2024

Fixes

Try fixing node in ov on MacOS

Description

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: mgmt Related to repo management and automations 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 26, 2024
@github-actions GitHub Actions
Copy link

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.8 GB  7.8 MB/s
     data_sent......................: 1.0 MB  4.5 kB/s
     http_req_blocked...............: avg=8.67µs   min=1.29µs  med=2.56µs   max=5.18ms  p(90)=3.6µs    p(95)=3.91µs  
     http_req_connecting............: avg=5.4µs    min=0s      med=0s       max=5.12ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=602.21ms min=27.31ms med=539.42ms max=2.59s   p(90)=1.12s    p(95)=1.25s   
       { expected_response:true }...: avg=602.21ms min=27.31ms med=539.42ms max=2.59s   p(90)=1.12s    p(95)=1.25s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=164.68µs min=41.16µs med=113.89µs max=19.58ms p(90)=188.41µs p(95)=236.14µs
     http_req_sending...............: avg=22.32µs  min=7.45µs  med=20.02µs  max=2.99ms  p(90)=27.01µs  p(95)=33.54µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=602.03ms min=27.18ms med=539.16ms max=2.59s   p(90)=1.12s    p(95)=1.25s   
     http_reqs......................: 8000    34.511165/s
     iteration_duration.............: avg=4.02s    min=1.15s   med=3.46s    max=12.75s  p(90)=8.71s    p(95)=9.25s   
     iterations.....................: 1200    5.176675/s
     vus............................: 9       min=9       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

@obulat obulat closed this Sep 26, 2024
@obulat obulat deleted the add/smoke-test-for-ov branch October 9, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🧱 stack: mgmt Related to repo management and automations 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obulat @openverse-bot